-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transactional retryer #548
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,11 @@ | ||
import pytest | ||
import ydb | ||
|
||
from typing import Optional | ||
|
||
from ydb.query.pool import QuerySessionPool | ||
from ydb.query.session import QuerySession, QuerySessionStateEnum | ||
from ydb.query.transaction import QueryTxContext | ||
|
||
|
||
class TestQuerySessionPool: | ||
|
@@ -46,6 +50,41 @@ def callee(session: QuerySession): | |
with pytest.raises(CustomException): | ||
pool.retry_operation_sync(callee) | ||
|
||
@pytest.mark.parametrize( | ||
"tx_mode", | ||
[ | ||
(None), | ||
(ydb.QuerySerializableReadWrite()), | ||
(ydb.QuerySnapshotReadOnly()), | ||
(ydb.QueryOnlineReadOnly()), | ||
(ydb.QueryStaleReadOnly()), | ||
], | ||
) | ||
def test_retry_tx_normal(self, pool: QuerySessionPool, tx_mode: Optional[ydb.BaseQueryTxMode]): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same about test for really retry |
||
retry_no = 0 | ||
|
||
def callee(tx: QueryTxContext): | ||
nonlocal retry_no | ||
if retry_no < 2: | ||
retry_no += 1 | ||
raise ydb.Unavailable("Fake fast backoff error") | ||
result_stream = tx.execute("SELECT 1") | ||
return [result_set for result_set in result_stream] | ||
|
||
result = pool.retry_tx_sync(callee=callee, tx_mode=tx_mode) | ||
assert len(result) == 1 | ||
assert retry_no == 2 | ||
|
||
def test_retry_tx_raises(self, pool: QuerySessionPool): | ||
class CustomException(Exception): | ||
pass | ||
|
||
def callee(tx: QueryTxContext): | ||
raise CustomException() | ||
|
||
with pytest.raises(CustomException): | ||
pool.retry_tx_sync(callee) | ||
|
||
def test_pool_size_limit_logic(self, pool: QuerySessionPool): | ||
target_size = 5 | ||
pool._size = target_size | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It need tests for really retry retriable errors. Simplest the error for reproduce- TLI.