Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update release label in monitoring crds #257

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

update release label in monitoring crds #257

wants to merge 2 commits into from

Conversation

kobzonega
Copy link
Contributor

@kobzonega kobzonega commented Oct 25, 2024 •
edited
Loading

for kube-prom-stack helm compatibility

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@kobzonega
Copy link
Contributor Author

It depends on Helm release name used for kube-prometheus-stack chart https://github.com/prometheus-community/helm-charts/blob/main/charts/kube-prometheus-stack/values.yaml#L3797-L3801
We should write about this in docs and Readme instead of change example manifests

@kobzonega kobzonega marked this pull request as draft January 27, 2025 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kobzonega