Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE for transaction id handling #344

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

alex268
Copy link
Member

@alex268 alex268 commented Nov 5, 2024

Fixes #342

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.21%. Comparing base (fe3af55) to head (da4f249).

Files with missing lines Patch % Lines
...src/main/java/tech/ydb/query/impl/SessionImpl.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #344   +/-   ##
=========================================
  Coverage     47.21%   47.21%           
  Complexity     1750     1750           
=========================================
  Files           311      311           
  Lines         12499    12498    -1     
  Branches       1238     1237    -1     
=========================================
  Hits           5901     5901           
  Misses         6138     6138           
+ Partials        460      459    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alex268 alex268 requested a review from pnv1 November 5, 2024 14:33
@alex268 alex268 merged commit 9f5bd59 into ydb-platform:master Nov 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE in query.impl.TableClientImpl happens on query error
3 participants