Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NullType support #293

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Added NullType support #293

merged 2 commits into from
Jul 5, 2024

Conversation

alex268
Copy link
Member

@alex268 alex268 commented Jul 5, 2024

No description provided.

@alex268 alex268 requested a review from pnv1 July 5, 2024 14:28
@alex268 alex268 self-assigned this Jul 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 76.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 45.85%. Comparing base (10c77c4) to head (e3cee70).

Files Patch % Lines
...src/main/java/tech/ydb/table/values/NullValue.java 40.00% 3 Missing ⚠️
...ch/ydb/table/result/impl/ProtoNullValueReader.java 66.66% 2 Missing ⚠️
.../src/main/java/tech/ydb/table/values/NullType.java 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #293      +/-   ##
============================================
+ Coverage     45.71%   45.85%   +0.14%     
- Complexity     1617     1638      +21     
============================================
  Files           300      303       +3     
  Lines         11846    11874      +28     
  Branches       1153     1153              
============================================
+ Hits           5415     5445      +30     
+ Misses         6017     6015       -2     
  Partials        414      414              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alex268 alex268 merged commit b024205 into master Jul 5, 2024
7 checks passed
@alex268 alex268 deleted the null_type_fix branch July 5, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants