Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bodyclose enabled #986

Merged
merged 2 commits into from
Dec 30, 2023
Merged

bodyclose enabled #986

merged 2 commits into from
Dec 30, 2023

Conversation

asmyasnikov
Copy link
Member

@asmyasnikov asmyasnikov commented Dec 30, 2023

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #919

What is the new behavior?

Other information

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c642118) 67.50% compared to head (87b5fb7) 67.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #986      +/-   ##
==========================================
- Coverage   67.50%   67.49%   -0.02%     
==========================================
  Files         261      261              
  Lines       24686    24686              
==========================================
- Hits        16664    16661       -3     
- Misses       7159     7161       +2     
- Partials      863      864       +1     
Flag Coverage Δ
54.08% <ø> (+0.02%) ⬆️
go-1.17.x 66.02% <ø> (+0.15%) ⬆️
go-1.20.x 67.33% <ø> (-0.18%) ⬇️
go-1.21.x 67.39% <ø> (+0.10%) ⬆️
integration 54.08% <ø> (+0.02%) ⬆️
macOS 38.82% <ø> (+<0.01%) ⬆️
ubuntu 38.83% <ø> (+<0.01%) ⬆️
unit 38.91% <ø> (ø)
windows 38.87% <ø> (-0.02%) ⬇️
ydb-22.5 53.80% <ø> (+0.10%) ⬆️
ydb-23.1 53.71% <ø> (-0.03%) ⬇️
ydb-23.2 53.82% <ø> (+0.25%) ⬆️
ydb-23.3 53.94% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

summary

Base version: v3.54.4-0.20231230173447-c64211879db5 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.54.3.

@asmyasnikov asmyasnikov merged commit 59e5a95 into master Dec 30, 2023
49 checks passed
@asmyasnikov asmyasnikov deleted the bodyclose branch December 30, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants