Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metadata to messages #912

Merged
merged 5 commits into from
Dec 18, 2023
Merged

add metadata to messages #912

merged 5 commits into from
Dec 18, 2023

Conversation

rekby
Copy link
Member

@rekby rekby commented Dec 15, 2023

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Close: #904

@rekby rekby marked this pull request as draft December 15, 2023 11:43
@rekby rekby force-pushed the topic-message-metadata branch from e8fc5f1 to 4685172 Compare December 15, 2023 11:45
Copy link

summary

Base version: v3.54.3-rc0.0.20231214160206-2ea00615f073 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.54.3-rc0.

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (f1d4f44) 66.50% compared to head (7fd9756) 67.44%.
Report is 2 commits behind head on master.

Files Patch % Lines
...al/grpcwrapper/rawtopic/rawtopicreader/messages.go 0.00% 7 Missing and 1 partial ⚠️
...al/grpcwrapper/rawtopic/rawtopicwriter/messages.go 0.00% 5 Missing and 1 partial ⚠️
internal/topic/topicreaderinternal/message.go 0.00% 6 Missing ⚠️
internal/topic/topicwriterinternal/message.go 70.00% 5 Missing and 1 partial ⚠️
internal/xbytes/clone.go 0.00% 5 Missing ⚠️
internal/xbytes/clone_go1.20.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #912      +/-   ##
==========================================
+ Coverage   66.50%   67.44%   +0.94%     
==========================================
  Files         258      260       +2     
  Lines       24618    24675      +57     
==========================================
+ Hits        16371    16641     +270     
+ Misses       7395     7170     -225     
- Partials      852      864      +12     
Flag Coverage Δ
54.10% <33.33%> (+1.03%) ⬆️
go-1.17.x 65.98% <53.73%> (+1.04%) ⬆️
go-1.20.x 67.27% <56.25%> (+0.94%) ⬆️
go-1.21.x 67.25% <56.25%> (+1.03%) ⬆️
integration 54.10% <33.33%> (+1.03%) ⬆️
macOS 38.78% <66.66%> (+0.06%) ⬆️
ubuntu 38.78% <66.66%> (+0.01%) ⬆️
unit 38.85% <66.66%> (+0.01%) ⬆️
windows 38.84% <66.66%> (+0.03%) ⬆️
ydb-22.5 53.90% <33.33%> (+1.05%) ⬆️
ydb-23.1 53.76% <33.33%> (+1.17%) ⬆️
ydb-23.2 53.55% <33.33%> (+0.88%) ⬆️
ydb-23.3 53.82% <33.33%> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-databasesql

Copy link

🌋 Here are results of SLO test for Go SDK native:

Grafana Dashboard

SLO-native

Copy link

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

@rekby rekby marked this pull request as ready for review December 15, 2023 13:49
@rekby rekby self-assigned this Dec 15, 2023
@asmyasnikov asmyasnikov merged commit 20660b3 into master Dec 18, 2023
49 checks passed
@asmyasnikov asmyasnikov deleted the topic-message-metadata branch December 18, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add metadata for every topic message
3 participants