Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CAS #885

Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix CAS #885

merged 1 commit into from
Nov 8, 2023

Conversation

asmyasnikov
Copy link
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov self-assigned this Nov 7, 2023
Copy link

github-actions bot commented Nov 7, 2023

summary

Base version: v3.54.2-0.20231107162155-4ec2ee9a33c8 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.54.1.

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ec2ee9) 66.65% compared to head (ce10101) 66.74%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #885      +/-   ##
==========================================
+ Coverage   66.65%   66.74%   +0.09%     
==========================================
  Files         255      255              
  Lines       24237    24236       -1     
==========================================
+ Hits        16154    16177      +23     
+ Misses       7242     7220      -22     
+ Partials      841      839       -2     
Flag Coverage Δ
53.32% <100.00%> (+0.07%) ⬆️
go-1.17.x 65.08% <100.00%> (-0.21%) ⬇️
go-1.20.x 66.39% <100.00%> (-0.23%) ⬇️
go-1.21.x 66.71% <100.00%> (+0.39%) ⬆️
integration 53.32% <100.00%> (+0.07%) ⬆️
macOS 39.10% <0.00%> (+0.01%) ⬆️
ubuntu 39.09% <0.00%> (-0.02%) ⬇️
unit 39.18% <0.00%> (-0.01%) ⬇️
windows 39.16% <0.00%> (+0.03%) ⬆️
ydb-22.5 52.93% <100.00%> (-0.04%) ⬇️
ydb-23.1 52.97% <100.00%> (-0.02%) ⬇️
ydb-23.2 52.76% <100.00%> (-0.23%) ⬇️
ydb-23.3 52.98% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/conn/conn.go 74.86% <100.00%> (-0.08%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmyasnikov asmyasnikov merged commit a00eddd into master Nov 8, 2023
47 of 48 checks passed
@asmyasnikov asmyasnikov deleted the fix-cas branch November 8, 2023 00:12
Copy link

github-actions bot commented Nov 8, 2023

🌋 Here are results of SLO test for Go SDK native:

Grafana Dashboard

SLO-native

Copy link

github-actions bot commented Nov 8, 2023

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Copy link

github-actions bot commented Nov 8, 2023

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

github-actions bot commented Nov 8, 2023

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-databasesql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants