Drop lazy init #884

asmyasnikov · 2023-11-07T15:34:27Z

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

…nd driver.go

…xplicit initialization on ydb.Open step

github-actions · 2023-11-07T15:36:17Z

github.com/ydb-platform/ydb-go-sdk/v3/trace

incompatible changes

TableOnInit: changed from func(*Table, *context.Context) func(limit int) to func(*Table, *context.Context) func(limit int, _ error)

compatible changes

TableInitDoneInfo.Error: added

summary

Base version: v3.54.2-0.20231104115311-d98f854166f9 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.54.1.

codecov-commenter · 2023-11-07T15:57:17Z

Codecov Report

Attention: 284 lines in your changes are missing coverage. Please review.

Comparison is base (d98f854) 66.92% compared to head (ab9e576) 39.18%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #884       +/-   ##
===========================================
- Coverage   66.92%   39.18%   -27.75%     
===========================================
  Files         255      210       -45     
  Lines       24245    21111     -3134     
===========================================
- Hits        16227     8272     -7955     
- Misses       7191    12491     +5300     
+ Partials      827      348      -479

Flag	Coverage Δ
	`?`
go-1.17.x	`38.89% <6.57%> (-26.66%)`	⬇️
go-1.20.x	`39.10% <6.57%> (-27.70%)`	⬇️
go-1.21.x	`39.08% <6.57%> (-27.55%)`	⬇️
integration	`?`
macOS	`39.08% <6.57%> (+0.01%)`	⬆️
ubuntu	`39.08% <6.57%> (-0.03%)`	⬇️
unit	`39.18% <6.57%> (-0.03%)`	⬇️
windows	`38.89% <6.57%> (-0.25%)`	⬇️
ydb-22.5	`?`
ydb-23.1	`?`
ydb-23.2	`?`
ydb-23.3	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
internal/table/client.go	`82.81% <100.00%> (-5.24%)`	⬇️
retry/retry.go	`60.62% <100.00%> (-13.75%)`	⬇️
internal/scheme/client.go	`0.00% <0.00%> (-61.36%)`	⬇️
internal/balancer/balancer.go	`24.89% <0.00%> (-59.28%)`	⬇️
driver.go	`3.54% <3.54%> (ø)`