Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Allowed sql.LevelSerializable isolation level in read-write mode … #882

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

asmyasnikov
Copy link
Member

…in database/sql transactions

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov added the enhancement New feature or request label Oct 26, 2023
@asmyasnikov asmyasnikov self-assigned this Oct 26, 2023
@github-actions
Copy link

summary

Base version: v3.54.0-rc0.0.20231025191723-4ae0dcb740ba (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.54.0-rc0.

@asmyasnikov asmyasnikov marked this pull request as ready for review October 26, 2023 10:07
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ae0dcb) 66.79% compared to head (da83f91) 66.85%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
+ Coverage   66.79%   66.85%   +0.06%     
==========================================
  Files         255      255              
  Lines       24240    24243       +3     
==========================================
+ Hits        16190    16208      +18     
+ Misses       7218     7207      -11     
+ Partials      832      828       -4     
Flag Coverage Δ
53.45% <100.00%> (+0.10%) ⬆️
go-1.17.x 65.41% <100.00%> (+0.11%) ⬆️
go-1.20.x 66.78% <100.00%> (+0.12%) ⬆️
go-1.21.x 66.72% <100.00%> (+0.09%) ⬆️
integration 53.45% <100.00%> (+0.10%) ⬆️
macOS 39.09% <100.00%> (+0.05%) ⬆️
ubuntu 39.07% <100.00%> (+0.01%) ⬆️
unit 39.17% <100.00%> (+0.03%) ⬆️
windows 39.12% <100.00%> (+<0.01%) ⬆️
ydb-22.5 53.22% <100.00%> (+0.04%) ⬆️
ydb-23.1 52.96% <100.00%> (-0.13%) ⬇️
ydb-23.2 52.93% <100.00%> (-0.04%) ⬇️
ydb-23.3 53.25% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/xsql/isolation/isolation.go 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmyasnikov asmyasnikov merged commit 5a37f51 into master Oct 26, 2023
@asmyasnikov asmyasnikov deleted the LevelSerializable branch October 26, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants