Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowed to create xerrors.TransportError() from grpc status error + r… #871

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

asmyasnikov
Copy link
Member

@asmyasnikov asmyasnikov commented Oct 23, 2023

…efactoring of xerrors tests

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@github-actions
Copy link

summary

Base version: v3.53.5-0.20231023081815-461b0fea1656 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.53.4.

@github-actions
Copy link

github-actions bot commented Oct 23, 2023

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

@github-actions
Copy link

github-actions bot commented Oct 23, 2023

🌋 Here are results of SLO test for Go SDK native:

Grafana Dashboard

SLO-native

@github-actions
Copy link

github-actions bot commented Oct 23, 2023

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

@github-actions
Copy link

github-actions bot commented Oct 23, 2023

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-databasesql

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (461b0fe) 66.25% compared to head (7a02231) 66.32%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
+ Coverage   66.25%   66.32%   +0.07%     
==========================================
  Files         253      254       +1     
  Lines       24004    24025      +21     
==========================================
+ Hits        15903    15935      +32     
+ Misses       7267     7256      -11     
  Partials      834      834              
Flag Coverage Δ
53.04% <20.00%> (+0.04%) ⬆️
go-1.17.x 64.82% <100.00%> (-0.11%) ⬇️
go-1.20.x 66.22% <100.00%> (+0.03%) ⬆️
go-1.21.x 66.05% <100.00%> (-0.03%) ⬇️
integration 53.04% <20.00%> (+0.04%) ⬆️
macOS 39.28% <100.00%> (-0.56%) ⬇️
ubuntu 39.28% <100.00%> (-0.58%) ⬇️
unit 39.36% <100.00%> (-0.59%) ⬇️
windows 39.31% <100.00%> (-0.58%) ⬇️
ydb-22.5 52.66% <20.00%> (+0.07%) ⬆️
ydb-23.1 52.77% <20.00%> (+0.07%) ⬆️
ydb-23.2 52.70% <20.00%> (+0.04%) ⬆️
ydb-23.3 52.80% <20.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/xerrors/transport.go 88.49% <100.00%> (+6.49%) ⬆️
internal/xtest/current_file_line.go 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…efactoring of xerrors tests + added xtest.CurrentFileLine()
@asmyasnikov asmyasnikov merged commit 2ea6388 into master Oct 23, 2023
48 of 49 checks passed
@asmyasnikov asmyasnikov deleted the xerrors branch October 23, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants