Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade dependencies from golang.org/x #861

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Downgrade dependencies from golang.org/x #861

merged 2 commits into from
Oct 19, 2023

Conversation

asmyasnikov
Copy link
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

* Downgrade `golang.org/x/sys` from `v0.13.0` to `v0.12.0`
* Downgrade `golang.org/x/crypto` from `v0.14.0` to `v0.13.0`
@asmyasnikov asmyasnikov added bug Something isn't working dependencies Pull requests that update a dependency file labels Oct 19, 2023
@asmyasnikov asmyasnikov self-assigned this Oct 19, 2023
@github-actions
Copy link

summary

Base version: v3.53.3 (master)
Suggested version: v3.53.4

@asmyasnikov asmyasnikov changed the title Downgrade x Downgrade dependencies from golang.org/x Oct 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (899fac3) 65.95% compared to head (be0dfa9) 63.97%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #861      +/-   ##
==========================================
- Coverage   65.95%   63.97%   -1.99%     
==========================================
  Files         253      252       -1     
  Lines       23892    23407     -485     
==========================================
- Hits        15759    14974     -785     
- Misses       7290     7606     +316     
+ Partials      843      827      -16     
Flag Coverage Δ
51.19% <ø> (-1.55%) ⬇️
go-1.17.x 63.95% <ø> (-0.57%) ⬇️
go-1.20.x 39.53% <ø> (-0.06%) ⬇️
go-1.21.x ?
integration 51.19% <ø> (-1.55%) ⬇️
macOS 39.49% <ø> (-0.02%) ⬇️
ubuntu 39.51% <ø> (+0.01%) ⬆️
unit 39.51% <ø> (-0.10%) ⬇️
windows ?
ydb-22.5 ?
ydb-23.1 ?
ydb-23.2 51.19% <ø> (-1.25%) ⬇️
ydb-23.3 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmyasnikov asmyasnikov merged commit 444cac4 into master Oct 19, 2023
@asmyasnikov asmyasnikov deleted the downgrade-x branch October 19, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants