* Refactored traces and metrics #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmyasnikov
added
bug
asmyasnikov
changed the title
trace.Retry into driver instance for usage in call `retry.R…trace.Retry into driver instance for usage in call retry.Retry func * Refactored traces and metrics * Renamed retry option WithID to WithLabel
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #860 +/- ##
==========================================
+ Coverage 66.85% 66.91% +0.06%
==========================================
Files 255 256 +1
Lines 24194 24253 +59
==========================================
+ Hits 16174 16230 +56
- Misses 7188 7191 +3
Partials 832 832
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
summaryBase version: v3.53.5-0.20231025180245-63560a5d46ac (master) |
asmyasnikov
force-pushed
the
metrics
branch
2 times, most recently
from
4a45a7e to
5531a04
Compare
|
🌋 Here are results of SLO test for Go SDK database/sql: |
|
🌋 Here are results of SLO test for Go SDK gorm: |
|
🌋 Here are results of SLO test for Go SDK xorm: |
|
🌋 Here are results of SLO test for Go SDK native: |
asmyasnikov
force-pushed
the
metrics
branch
6 times, most recently
from
131dce0 to
df05d09
Compare
asmyasnikov
changed the title
trace.Retry into driver instance for usage in call retry.Retry func * Refactored traces and metrics * Renamed retry option WithID to WithLabel
asmyasnikov
force-pushed
the
metrics
branch
2 times, most recently
from
e1f6c53 to
0729d76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #477
What is the new behavior?
Other information