enable thelper linter

.golangci.yml

@@ -243,7 +243,6 @@ linters:
     - structcheck
     - testableexamples
     - testpackage
-    - thelper
     - varnamelen
     - wrapcheck
     - wsl

internal/background/worker_test.go

@@ -96,14 +96,15 @@ func TestWorkerClose(t *testing.T) {
 }
 
 func TestWorkerConcurrentStartAndClose(t *testing.T) {
-	xtest.TestManyTimes(t, func(t testing.TB) {
+	xtest.TestManyTimes(t, func(tb testing.TB) {
+		tb.Helper()
 		targetClose := int64(10)
 
 		parallel := runtime.GOMAXPROCS(0)
 
 		var counter xatomic.Int64
 
-		ctx := xtest.Context(t)
+		ctx := xtest.Context(tb)
 		w := NewWorker(ctx)
 
 		stopNewStarts := xatomic.Bool{}
@@ -126,24 +127,25 @@ func TestWorkerConcurrentStartAndClose(t *testing.T) {
 		}
 
 		// wait start some backgrounds - for ensure about process worked
-		xtest.SpinWaitCondition(t, nil, func() bool {
+		xtest.SpinWaitCondition(tb, nil, func() bool {
 			return counter.Load() > targetClose
 		})
 
-		require.NoError(t, w.Close(xtest.ContextWithCommonTimeout(ctx, t), nil))
+		require.NoError(tb, w.Close(xtest.ContextWithCommonTimeout(ctx, tb), nil))
 
 		stopNewStarts.Store(true)
-		xtest.WaitGroup(t, &wgStarters)
+		xtest.WaitGroup(tb, &wgStarters)
 
 		_, ok := <-w.tasks
-		require.False(t, ok)
-		require.True(t, w.closed)
+		require.False(tb, ok)
+		require.True(tb, w.closed)
 	})
 }
 
 func TestWorkerStartCompletedWhileLongWait(t *testing.T) {
-	xtest.TestManyTimes(t, func(t testing.TB) {
-		ctx := xtest.Context(t)
+	xtest.TestManyTimes(t, func(tb testing.TB) {
+		tb.Helper()
+		ctx := xtest.Context(tb)
 		w := NewWorker(ctx)
 
 		allowStop := make(empty.Chan)
@@ -175,17 +177,17 @@ func TestWorkerStartCompletedWhileLongWait(t *testing.T) {
 			_ = w.Close(ctx, nil)
 		}()
 
-		xtest.WaitChannelClosed(t, callStartFinished)
+		xtest.WaitChannelClosed(tb, callStartFinished)
 		runtime.Gosched()
 
 		select {
 		case <-closed:
-			t.Fatal()
+			tb.Fatal()
 		default:
 			// pass
 		}
 
 		close(allowStop)
-		xtest.WaitChannelClosed(t, closed)
+		xtest.WaitChannelClosed(tb, closed)
 	})
 }

internal/balancer/local_dc_test.go

@@ -96,22 +96,23 @@ func TestCheckFastestAddress(t *testing.T) {
 
 func TestDetectLocalDC(t *testing.T) {
 	ctx := context.Background()
-	xtest.TestManyTimesWithName(t, "Ok", func(t testing.TB) {
+	xtest.TestManyTimesWithName(t, "Ok", func(tb testing.TB) {
+		tb.Helper()
 		listen1, err := net.ListenTCP("tcp", &net.TCPAddr{IP: localIP})
-		require.NoError(t, err)
+		require.NoError(tb, err)
 		defer func() { _ = listen1.Close() }()
 
 		listen2, err := net.ListenTCP("tcp", &net.TCPAddr{IP: localIP})
-		require.NoError(t, err)
+		require.NoError(tb, err)
 		listen2Addr := listen2.Addr().String()
 		_ = listen2.Close() // force close, for not accept tcp connections
 
 		dc, err := detectLocalDC(ctx, []endpoint.Endpoint{
 			&mock.Endpoint{LocationField: "a", AddrField: "grpc://" + listen1.Addr().String()},
 			&mock.Endpoint{LocationField: "b", AddrField: "grpc://" + listen2Addr},
 		})
-		require.NoError(t, err)
-		require.Equal(t, "a", dc)
+		require.NoError(tb, err)
+		require.Equal(tb, "a", dc)
 	})
 	t.Run("Empty", func(t *testing.T) {
 		res, err := detectLocalDC(ctx, nil)
@@ -222,12 +223,13 @@ func TestGetRandomEndpoints(t *testing.T) {
 		res = getRandomEndpoints(source, 4)
 		require.Equal(t, source, res)
 	})
-	xtest.TestManyTimesWithName(t, "SelectRandom", func(t testing.TB) {
+	xtest.TestManyTimesWithName(t, "SelectRandom", func(tb testing.TB) {
+		tb.Helper()
 		res := getRandomEndpoints(source, 2)
-		require.Len(t, res, 2)
+		require.Len(tb, res, 2)
 		for _, ep := range res {
-			require.Contains(t, source, ep)
+			require.Contains(tb, source, ep)
 		}
-		require.NotEqual(t, res[0], res[1])
+		require.NotEqual(tb, res[0], res[1])
 	})
 }