Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make the error StatusIds_SESSION_EXPIRED retriable #1014

Conversation

v1tbrah
Copy link
Contributor

@v1tbrah v1tbrah commented Jan 24, 2024

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

  • Bugfix

What is the current behavior?

Issue Number: 863

SessionExpired is non retriable error

What is the new behavior?

SessionExpired is retriable error

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ed57546) 67.50% compared to head (41a55ef) 67.52%.

Files Patch % Lines
internal/xerrors/operation.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1014      +/-   ##
==========================================
+ Coverage   67.50%   67.52%   +0.01%     
==========================================
  Files         252      252              
  Lines       24508    24508              
==========================================
+ Hits        16545    16549       +4     
+ Misses       7100     7097       -3     
+ Partials      863      862       -1     
Flag Coverage Δ
54.04% <0.00%> (+0.04%) ⬆️
go-1.20.x 67.40% <0.00%> (+0.02%) ⬆️
go-1.21.x 67.30% <0.00%> (-0.10%) ⬇️
integration 54.04% <0.00%> (+0.04%) ⬆️
macOS 38.82% <0.00%> (-0.02%) ⬇️
ubuntu 38.85% <0.00%> (+0.01%) ⬆️
unit 38.93% <0.00%> (ø)
windows 38.89% <0.00%> (+0.03%) ⬆️
ydb-22.5 53.66% <0.00%> (+<0.01%) ⬆️
ydb-23.1 53.64% <0.00%> (+0.13%) ⬆️
ydb-23.2 53.72% <0.00%> (+0.14%) ⬆️
ydb-23.3 53.74% <0.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
retry/errors_data_test.go Outdated Show resolved Hide resolved
internal/xerrors/operation.go Outdated Show resolved Hide resolved
internal/xerrors/operation.go Outdated Show resolved Hide resolved
internal/xerrors/operation.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
tests/slo/go.sum Outdated Show resolved Hide resolved
tests/slo/go.sum Outdated Show resolved Hide resolved
tests/slo/go.sum Outdated Show resolved Hide resolved
tests/slo/go.sum Outdated Show resolved Hide resolved
tests/slo/go.sum Outdated Show resolved Hide resolved
examples/go.sum Outdated Show resolved Hide resolved
examples/go.sum Outdated Show resolved Hide resolved
examples/go.sum Outdated Show resolved Hide resolved
examples/go.sum Outdated Show resolved Hide resolved
examples/go.sum Outdated Show resolved Hide resolved
@v1tbrah
Copy link
Contributor Author

v1tbrah commented Jan 25, 2024

Hello, @asmyasnikov
As I can see in your commits, I didn't understand the issue enough well
But now what do I need to do/fix for getting approve?

@asmyasnikov asmyasnikov merged commit a4cc963 into ydb-platform:master Jan 25, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants