Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled wastedassign #1010

Merged
merged 3 commits into from
Jan 24, 2024
Merged

enabled wastedassign #1010

merged 3 commits into from
Jan 24, 2024

Conversation

size12
Copy link
Contributor

@size12 size12 commented Jan 24, 2024

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

enabled wastedassign linter

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #975

What is the new behavior?

Other information

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (96e641b) 67.52% compared to head (a9ce335) 67.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1010      +/-   ##
==========================================
- Coverage   67.52%   67.42%   -0.11%     
==========================================
  Files         252      252              
  Lines       24509    24508       -1     
==========================================
- Hits        16550    16524      -26     
- Misses       7097     7117      +20     
- Partials      862      867       +5     
Flag Coverage Δ
53.91% <100.00%> (-0.10%) ⬇️
go-1.20.x 67.30% <100.00%> (-0.11%) ⬇️
go-1.21.x 67.29% <100.00%> (-0.03%) ⬇️
integration 53.91% <100.00%> (-0.10%) ⬇️
macOS 38.80% <100.00%> (+<0.01%) ⬆️
ubuntu 38.85% <100.00%> (-0.02%) ⬇️
unit 38.92% <100.00%> (-0.02%) ⬇️
windows 38.88% <100.00%> (+0.02%) ⬆️
ydb-22.5 53.37% <100.00%> (-0.40%) ⬇️
ydb-23.1 53.62% <100.00%> (-0.17%) ⬇️
ydb-23.2 53.54% <100.00%> (+0.14%) ⬆️
ydb-23.3 53.45% <100.00%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmyasnikov asmyasnikov merged commit 693fdbb into ydb-platform:master Jan 24, 2024
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants