Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled testifylint #1009

Merged
merged 4 commits into from
Jan 23, 2024
Merged

enabled testifylint #1009

merged 4 commits into from
Jan 23, 2024

Conversation

size12
Copy link
Contributor

@size12 size12 commented Jan 23, 2024

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Fixed testifylint warnings.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

testifylint doesn't show warnings.

Issue Number: #970

CHANGELOG.md Outdated
@@ -1,3 +1,5 @@
* Enabled testifylint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add a line about build/CI changes
Runtime code of ydb-go-sdk has no changes

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a848794) 67.39% compared to head (f974670) 54.09%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1009       +/-   ##
===========================================
- Coverage   67.39%   54.09%   -13.31%     
===========================================
  Files         252      252               
  Lines       24509    24509               
===========================================
- Hits        16518    13257     -3261     
- Misses       7122    10295     +3173     
- Partials      869      957       +88     
Flag Coverage Δ
54.09% <ø> (+0.18%) ⬆️
go-1.20.x 53.96% <ø> (-13.31%) ⬇️
go-1.21.x 53.89% <ø> (-13.48%) ⬇️
integration 54.09% <ø> (+0.18%) ⬆️
macOS ?
ubuntu ?
unit ?
windows ?
ydb-22.5 53.75% <ø> (+0.47%) ⬆️
ydb-23.1 53.56% <ø> (-0.20%) ⬇️
ydb-23.2 53.79% <ø> (+0.19%) ⬆️
ydb-23.3 53.74% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmyasnikov asmyasnikov merged commit 96e641b into ydb-platform:master Jan 23, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants