Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

respond with fatal errors to CMS requests in some cases #845

Merged
merged 4 commits into from
Mar 28, 2024
Merged

respond with fatal errors to CMS requests in some cases #845

merged 4 commits into from
Mar 28, 2024

Conversation

sharpeye
Copy link
Collaborator

Return E_INVALID_STATE when ADD_HOST tries to add an unavailable host and when ADD_DEVICE tries to add a broken device

@sharpeye sharpeye added the blockstore Add this label to run only cloud/blockstore build and tests on PR label Mar 28, 2024
@sharpeye sharpeye changed the title return fatal errors on CMS requests in some cases respond with fatal errors to CMS requests in some cases Mar 28, 2024
komarevtsev-d
komarevtsev-d previously approved these changes Mar 28, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit e4ce280.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2942 2942 0 0 0 0

@sharpeye sharpeye force-pushed the users/sharpeye/cms-errors branch from e4ce280 to b8205f9 Compare March 28, 2024 16:13
@sharpeye sharpeye force-pushed the users/sharpeye/cms-errors branch from b8205f9 to 619fb6f Compare March 28, 2024 16:15
@sharpeye sharpeye requested a review from komarevtsev-d March 28, 2024 16:16
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 619fb6f.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2942 2942 0 0 0 0

@sharpeye sharpeye merged commit fd51e9f into main Mar 28, 2024
7 checks passed
@sharpeye sharpeye deleted the users/sharpeye/cms-errors branch March 28, 2024 16:50
sharpeye added a commit that referenced this pull request Mar 28, 2024
@sharpeye
respond with fatal errors to CMS requests in some cases (#845)
e332fd9 
Return E_INVALID_STATE when ADD_HOST tries to add an unavailable host and when ADD_DEVICE tries to add a broken device
@sharpeye sharpeye mentioned this pull request Mar 28, 2024
Merged
sharpeye added a commit that referenced this pull request Apr 2, 2024
@sharpeye
merge to stable-23-3 (#854)
7a35a1d 
* #845
* #183
* #811
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komarevtsev-d komarevtsev-d komarevtsev-d approved these changes

@tpashkin tpashkin tpashkin approved these changes

@qkrorlqr qkrorlqr Awaiting requested review from qkrorlqr

Assignees
No one assigned
Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharpeye @tpashkin @komarevtsev-d