Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#831: [Disk Manager] validate crc32 for each block; log new crc32 for each block after writing in tests; #836

Merged
merged 4 commits into from
Apr 2, 2024
Merged

#831: [Disk Manager] validate crc32 for each block; log new crc32 for each block after writing in tests; #836

merged 4 commits into from
Apr 2, 2024

Conversation

BarkovBG
Copy link
Collaborator

@BarkovBG BarkovBG commented Mar 27, 2024 •
edited
Loading

@BarkovBG BarkovBG marked this pull request as ready for review March 27, 2024 16:17
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 2af2746.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5064 5062 0 2 0 0

@BarkovBG BarkovBG marked this pull request as draft March 28, 2024 09:32
@BarkovBG BarkovBG force-pushed the users/barkovbg/clientid branch 2 times, most recently from 9387efa to 21fd1ce Compare March 28, 2024 13:04
@BarkovBG BarkovBG changed the title #831: [Disk Manager] write the clientid at the beginning of the data … #831: [Disk Manager] validate crc32 for each block Mar 28, 2024
@BarkovBG BarkovBG force-pushed the users/barkovbg/clientid branch 3 times, most recently from 5f559d3 to 58a8bb3 Compare March 28, 2024 13:23
@BarkovBG BarkovBG changed the title #831: [Disk Manager] validate crc32 for each block #831: [Disk Manager] validate crc32 for each block; log new crc32 for each block after writing in tests; Mar 28, 2024
@BarkovBG BarkovBG force-pushed the users/barkovbg/clientid branch 2 times, most recently from 89087f4 to 7411368 Compare March 28, 2024 13:34
@BarkovBG BarkovBG added large-tests Launch large tests for PR disk_manager Add this label to run only cloud/disk_manager build and tests on PR labels Mar 28, 2024
@BarkovBG BarkovBG force-pushed the users/barkovbg/clientid branch from 7411368 to c0074dc Compare March 28, 2024 13:45
@BarkovBG BarkovBG marked this pull request as ready for review March 28, 2024 13:48
@BarkovBG BarkovBG force-pushed the users/barkovbg/clientid branch from e8aed5a to 7cd29a4 Compare March 28, 2024 16:32
@librarian librarian added rebase Add this label if you want to rebase your PR for test run and removed rebase Add this label if you want to rebase your PR for test run labels Mar 28, 2024
@BarkovBG BarkovBG force-pushed the users/barkovbg/clientid branch 2 times, most recently from 00302cd to e5f3eb8 Compare March 29, 2024 09:46
@BarkovBG BarkovBG force-pushed the users/barkovbg/clientid branch 4 times, most recently from 47e808d to ad8204e Compare March 29, 2024 14:32
@BarkovBG BarkovBG force-pushed the users/barkovbg/clientid branch from ad8204e to 4bc6beb Compare March 29, 2024 15:30
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 4bc6beb.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
803 803 0 0 0 0

@BarkovBG BarkovBG merged commit 723b716 into main Apr 2, 2024
7 checks passed
@BarkovBG BarkovBG deleted the users/barkovbg/clientid branch April 2, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SvartMetal SvartMetal SvartMetal approved these changes

@drbasic drbasic drbasic approved these changes

Assignees
No one assigned
Labels
disk_manager Add this label to run only cloud/disk_manager build and tests on PR large-tests Launch large tests for PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BarkovBG @drbasic @SvartMetal @librarian