issue-196: block checksums should be calculated after we copy the data from the client's buffer to our buffer, otherwise our client may modify the data between the checksum calculation stage and the writeblob stage #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a from the client's buffer to our buffer, otherwise our client may modify the data between the checksum calculation stage and the writeblob stage
qkrorlqr
added
the
blockstore
SvartMetal
reviewed
Mar 26, 2024
cloud/blockstore/libs/storage/partition/part_actor_writemergedblocks.cpp
Show resolved
Hide resolved
SvartMetal
approved these changes
Mar 26, 2024
yegorskii
approved these changes
Mar 26, 2024
qkrorlqr
added a commit
that referenced
this pull request
Mar 29, 2024
…a from the client's buffer to our buffer, otherwise our client may modify the data between the checksum calculation stage and the writeblob stage (#825) * issue-196: block checksums should be calculated after we copy the data from the client's buffer to our buffer, otherwise our client may modify the data between the checksum calculation stage and the writeblob stage * issue-196: small block checksums-related fix for the unconfirmed blobs datapath * issue-196: fixed unconfirmed blobs + checksums ut * issue-196: unconfirmed blobs + checksums - added a comment
qkrorlqr
added a commit
that referenced
this pull request
Mar 29, 2024
* issue-196: block checksums should be calculated after we copy the data from the client's buffer to our buffer, otherwise our client may modify the data between the checksum calculation stage and the writeblob stage (#825) * issue-196: block checksums should be calculated after we copy the data from the client's buffer to our buffer, otherwise our client may modify the data between the checksum calculation stage and the writeblob stage * issue-196: small block checksums-related fix for the unconfirmed blobs datapath * issue-196: fixed unconfirmed blobs + checksums ut * issue-196: unconfirmed blobs + checksums - added a comment * issue-196: fixed incorrect assert (#826) * blockstore loadtests: extracted common TStorageServiceConfig initialization code to a function, limiting bw by 32MiB/s in this function, using it in network-ssd/network-hdd loadtests (#828) * blockstore loadtests: extracted common TStorageServiceConfig initialization code to a function, limiting bw by 32MiB/s in this function, using it in network-ssd/network-hdd loadtests * blockstore loadtests: deleted unused imports * issue-95: enabling average compaction and cleanup thresholds in the newfeatures suite (#842) * issue-843: making TProcessingBlocks::SkipProcessedRanges 1024 times faster (#858) * issue-654: limiting the number of volume MetaHistory records displayed on volume monpage (#859) * fix after merge * another fix after merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#196