Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NBSNEBIUS-197: StartEndpointRequest creates socket file if needed #813

Merged
merged 1 commit into from
Mar 26, 2024
Merged

NBSNEBIUS-197: StartEndpointRequest creates socket file if needed #813

merged 1 commit into from
Mar 26, 2024

Conversation

sanek325
Copy link
Collaborator

@sanek325 sanek325 commented Mar 25, 2024 •
edited
Loading

There is a case when kubelet removes a created socket and sends again StartEndpointRequest to NBS. Then NBS reply S_ALREADY, but don’t recreate socket.
#101

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 58493d5.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5059 5052 0 4 1 2

@sanek325 sanek325 force-pushed the NBSNEBIUS-197 branch 2 times, most recently from 8030b3f to f07b10d Compare March 25, 2024 17:28
yegorskii
yegorskii previously approved these changes Mar 25, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit f07b10d.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5061 5055 0 2 2 2

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 02943a8.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5060 5056 0 0 2 2

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 5473b34.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5059 5056 0 0 1 2

@sanek325 sanek325 merged commit 03e9d4a into main Mar 26, 2024
7 checks passed
@sanek325 sanek325 deleted the NBSNEBIUS-197 branch March 26, 2024 12:32
sanek325 added a commit that referenced this pull request Mar 27, 2024
@sanek325
NBSNEBIUS-197: StartEndpointRequest creates socket file if needed (#813)
3b8efe5
sanek325 added a commit that referenced this pull request Mar 28, 2024
@sanek325
Merge to stable-23-3 (#839)
b37590b 
* NBSNEBIUS-197: StartEndpointRequest creates socket file if needed (#813)

* Fix asan test (#822)

* issue-463: add nbdDevicePrefix to config (#833)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@budevg budevg budevg approved these changes

@yegorskii yegorskii yegorskii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanek325 @budevg @yegorskii