Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase fix #730

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Rebase fix #730

merged 1 commit into from
Mar 13, 2024

Conversation

librarian
Copy link
Member

@librarian librarian commented Mar 13, 2024 •
edited
Loading

By default checkout fetches only latest commit fetch-depth: 1.
To rebase we need to fetch some amount of commits PR commits + previous one, and then you can rebase it. But in GA you cant determine amount of commits to fetch so we fetch all fetch-depth: 0 but realistically we can fetch some ambigious amount like 100 and this should be enough in most cases.

@github-actions GitHub Actions
Copy link
Contributor

Treating build_and_test_act.yaml as a Workflow definition
Treating build_and_test_act_cmake.yaml as a Workflow definition
Treating nightly.yaml as a Workflow definition
Treating build_and_test_on_demand_cmake.yaml as a Workflow definition
Treating pr.yaml as a Workflow definition
Treating pr-github-actions.yaml as a Workflow definition
Treating build_and_test_cmake.yaml as a Workflow definition
Treating build_and_test_ya.yaml as a Workflow definition
Treating pr-cmake.yaml as a Workflow definition
Treating github_actions_scripts.yaml as a Workflow definition
Treating nightly-index-rebuild.yaml as a Workflow definition
Treating build_and_test_on_demand.yaml as a Workflow definition

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x64-relwithdebinfo: some tests FAILED for commit 20261e6.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5015 4903 0 62 5 45

@librarian librarian added the rebase Add this label if you want to rebase your PR for test run label Mar 13, 2024
@librarian librarian force-pushed the users/librarian/rebase-fix branch from 20261e6 to aa870dc Compare March 13, 2024 17:21
@librarian librarian removed the rebase Add this label if you want to rebase your PR for test run label Mar 13, 2024
@librarian librarian changed the title Users/librarian/rebase fix Rebase fix Mar 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Treating build_and_test_act.yaml as a Workflow definition
Treating build_and_test_act_cmake.yaml as a Workflow definition
Treating nightly.yaml as a Workflow definition
Treating build_and_test_on_demand_cmake.yaml as a Workflow definition
Treating pr.yaml as a Workflow definition
Treating pr-github-actions.yaml as a Workflow definition
Treating build_and_test_cmake.yaml as a Workflow definition
Treating build_and_test_ya.yaml as a Workflow definition
Treating pr-cmake.yaml as a Workflow definition
Treating github_actions_scripts.yaml as a Workflow definition
Treating nightly-index-rebuild.yaml as a Workflow definition
Treating build_and_test_on_demand.yaml as a Workflow definition

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x64-relwithdebinfo: some tests FAILED for commit aa870dc.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5015 4903 0 62 5 45

@librarian librarian merged commit 4a5628f into main Mar 13, 2024
4 checks passed
@librarian librarian deleted the users/librarian/rebase-fix branch March 13, 2024 17:51
qkrorlqr pushed a commit that referenced this pull request Mar 14, 2024
@librarian @qkrorlqr
fix: fetch all commits history if we want to rebase (#730)
84c0129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BarkovBG BarkovBG BarkovBG approved these changes

@qkrorlqr qkrorlqr qkrorlqr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@librarian @qkrorlqr @BarkovBG