Write all crit events to cerr #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komarevtsev-d
previously approved these changes
Mar 11, 2024
komarevtsev-d
previously approved these changes
Mar 14, 2024
qkrorlqr
reviewed
Mar 14, 2024
qkrorlqr
reviewed
Mar 14, 2024
drbasic
force-pushed
the
users/drbasic/always-log-critevent
branch
from
102627c to
1c2d520
Compare
komarevtsev-d
approved these changes
Mar 28, 2024
qkrorlqr
approved these changes
Mar 28, 2024
qkrorlqr
pushed a commit
that referenced
this pull request
Nov 28, 2024
* Write all crit events to cerr * Make writing almost atomic * Use global logger
qkrorlqr
added a commit
that referenced
this pull request
Nov 28, 2024
* Write all crit events to cerr (#696) * Write all crit events to cerr * Make writing almost atomic * Use global logger * fixed build after merge --------- Co-authored-by: drbasic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.