[NBS] Asynchronous disks allocation #2763
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ya-ksgamora
force-pushed
the
users/ya-ksgamora/NBS-5637
branch
3 times, most recently
from
e6ba142 to
7f1eb3a
Compare
ya-ksgamora
force-pushed
the
users/ya-ksgamora/NBS-5637
branch
2 times, most recently
from
38c1991 to
9842b53
Compare
ya-ksgamora
force-pushed
the
users/ya-ksgamora/NBS-5637
branch
from
9842b53 to
2460bac
Compare
ya-ksgamora
changed the title
| args.SyncDeallocatedDisks = | ||
| State->MarkDevicesAsClean(ctx.Now(), db, args.Devices); | ||
| std::tie(args.SyncAllocatedDisks, args.SyncDeallocatedDisks) = | ||
| std::move(State->MarkDevicesAsClean(ctx.Now(), db, args.Devices)); |
|
|
||
| template <typename T, typename U> | ||
| using TOpt2 = std::pair<std::optional<T>, std::optional<U>>; | ||
| using TOpt2Disk = TOpt2<TAllocatingDiskId, TDeallocatingDiskId>; |
There was a problem hiding this comment.
struct TOpt2Disk {
TString AllocatingDiskId;
TString DeallocatingDiskId;
}
| return isAllocatingDisk || isDeallocatingDisk; | ||
| }); | ||
|
|
||
| Y_ABORT_IF(isAllocatingDisk && isDeallocatingDisk); |
There was a problem hiding this comment.
Y_DEBUG_ABORT_UNLESS(!isAllocatingDisk || !isDeallocatingDisk)
| auto TDiskRegistryState::FindDiskDevicesAgents(const TDiskState& disk) const | ||
| -> std::set<const NProto::TAgentConfig*> | ||
| { | ||
| std::set<TString> diskAgents; |
There was a problem hiding this comment.
THashSet<> diskAgentIds
| agents.insert(AgentList.FindAgent(agentId)); | ||
| } | ||
|
|
||
| return std::move(agents); |
| diskAgents.insert(DeviceList.FindAgentId(uuid)); | ||
| } | ||
|
|
||
| std::set<const NProto::TAgentConfig*> agents; |
komarevtsev-d
added
large-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.