Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shadow disk notification #2619

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Fix shadow disk notification #2619

merged 1 commit into from
Dec 4, 2024

Conversation

drbasic
Copy link
Collaborator

@drbasic drbasic commented Dec 4, 2024

Исправляется недоделки:

  1. DiskRegistry больше не пытается делать миграции устройств теневых дисков.
  2. DiskRegistry при нотификации об изменении конфига теневого диска теперь идет в диск источника. Это нужно если например NodeId дискагента под теневым диском поменялся. [NBS] Shadow disks do not support DA node id changes #2609

@drbasic drbasic added the blockstore Add this label to run only cloud/blockstore build and tests on PR label Dec 4, 2024
@drbasic drbasic mentioned this pull request Dec 4, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit b87807f.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3524 3523 0 1 0 0

@drbasic drbasic merged commit c7827b3 into main Dec 4, 2024
10 of 12 checks passed
@drbasic drbasic deleted the users/drbasic/fix-shadow-disk-notify branch December 4, 2024 09:19
drbasic added a commit that referenced this pull request Dec 5, 2024
@drbasic
Fix shadow disk notification (#2619)
0a64e1d
drbasic added a commit that referenced this pull request Dec 6, 2024
@drbasic
Users/drbasic/23 3 shadow disk fixes (#2628)
ccb772d 
* Destroy shadow disk actor before shadow disk deallocation (#2494)

* Destroy shadow disk actor before shadow disk deallocation

* Wait for partition stopped before shadow disk destroy

* Tests

* Fix review issues

* Simplify companion for GetChangedBlocksRequest (#2536)

* Simplify companion for GetChangedBlocksRequest

* Fix review issues

* Make free function DeclineGetChangedBlocks()

* Move code to part_nonrepl_common.cpp file (#2563)

* Move code to part_nonrepl_common.cpp file

* Fix review issues

* Remove unused param (#2604)

* Always call AugmentErrorFlags in ProcessError (#2617)

* Fix shadow disk notification (#2619)

* Fix compilation error
@drbasic drbasic mentioned this pull request Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komarevtsev-d komarevtsev-d komarevtsev-d approved these changes

@sharpeye sharpeye sharpeye approved these changes

Assignees
No one assigned
Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drbasic @sharpeye @komarevtsev-d