Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Disk Manager] Support creation image from NRD disks #2612

Merged
merged 15 commits into from
Jan 21, 2025
Merged

[Disk Manager] Support creation image from NRD disks #2612

merged 15 commits into from
Jan 21, 2025

Conversation

Rattysed
Copy link
Collaborator

@Rattysed Rattysed commented Dec 3, 2024

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

BarkovBG
BarkovBG reviewed Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@BarkovBG BarkovBG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а large-test для создания образа из nrd есть?
если нет, то нужно добавить

cloud/disk_manager/internal/pkg/clients/nbs/client.go Show resolved Hide resolved
cloud/disk_manager/internal/pkg/services/images/create_image_from_disk_task_test.go Outdated Show resolved Hide resolved
cloud/disk_manager/internal/pkg/services/images/create_image_from_disk_task_test.go Outdated Show resolved Hide resolved
BarkovBG
BarkovBG requested changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@BarkovBG BarkovBG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а large-test для создания образа из nrd есть?
если нет, то нужно добавить

@Rattysed Rattysed requested a review from BarkovBG December 5, 2024 14:54
@gy2411 gy2411 added disk_manager Add this label to run only cloud/disk_manager build and tests on PR large-tests Launch large tests for PR ok-to-test Label to approve test launch for external members labels Dec 6, 2024
@github-actions github-actions bot removed the ok-to-test Label to approve test launch for external members label Dec 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 32b834b.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
858 858 0 0 0 0

@gy2411 gy2411 mentioned this pull request Dec 13, 2024
Open
BarkovBG
BarkovBG previously approved these changes Jan 17, 2025
View reviewed changes
@BarkovBG BarkovBG added the ok-to-test Label to approve test launch for external members label Jan 20, 2025
@github-actions github-actions bot removed the ok-to-test Label to approve test launch for external members label Jan 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit fd14455.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
860 860 0 0 0 0

@Rattysed Rattysed added the ok-to-test Label to approve test launch for external members label Jan 21, 2025
@github-actions github-actions bot removed the ok-to-test Label to approve test launch for external members label Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit c7f9e63.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
856 856 0 0 0 0

@Rattysed Rattysed merged commit 670acaf into ydb-platform:main Jan 21, 2025
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gy2411 gy2411 gy2411 left review comments

@BarkovBG BarkovBG BarkovBG approved these changes

@SvartMetal SvartMetal SvartMetal approved these changes

Assignees
No one assigned
Labels
disk_manager Add this label to run only cloud/disk_manager build and tests on PR large-tests Launch large tests for PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rattysed @SvartMetal @BarkovBG @gy2411