Update installation.md #199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, YAZI_FILE_ONE environment variable should be specified without double quotes. With double quotes the variable is processed as below
YAZI_FILE_ONE : Some("\"C:\\Program Files\\Git\\usr\\bin\\file.exe\"")
and results in
file : The filename, directory name, or volume label syntax is incorrect. (os error 123)
|
I think it depends on how the user has set it up. If it's set in the system environment variables, then no quotes are needed, but if it's set in the PowerShell configuration file, then quotes are required. |
|
Good point. Instead of the current change, should I add a note that the double quotes should not be provided when setting the environment variable via Windows system UI(sysdm.cpl). Or better let me take a shot at fixing the issue in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows,
YAZI_FILE_ONEenvironment variable should be specified without double quotes. With double quotes the variable is processed as below. Resulting in file preview not working.YAZI_FILE_ONE : Some(""C:\Program Files\Git\usr\bin\file.exe"")
file : The filename, directory name, or volume label syntax is incorrect. (os error 123)