Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not test exact wording in xml exception #1314

Merged
merged 2 commits into from
Jan 2, 2025
Merged

do not test exact wording in xml exception #1314

merged 2 commits into from
Jan 2, 2025

Conversation

jreidinger
Copy link
Member

Problem

Ruby 3.4 use nicer formatting in inspect. And Yast2.rpm tests failing. with something like

expected Yast::XMLSerializationError with message matching /represent nil, part of .*"c"=>nil/, got #<Yast::XMLSerializationError: Cannot represent nil, part of {"a" => "b", "b" => "c", "c" => nil, "d" => "e", "e" => "f"}>

Solution

Do not test exact wording in yast exception and test just that exception is properly raised with proper type.

@coveralls
Copy link

coveralls commented Jan 2, 2025

Coverage Status

coverage: 41.889%. remained the same
when pulling 0b30d36 on ruby34
into 717d99f on master.

@jreidinger jreidinger merged commit 037b94b into master Jan 2, 2025
12 checks passed
@jreidinger jreidinger deleted the ruby34 branch January 2, 2025 09:40
Copy link

github-actions bot commented Jan 2, 2025

✅ Autosubmission job #12580438554 successfully finished
✅ Created submit request #1234526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants