Add bird in Autotest. #264
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ol-imorozko
requested changes
Jan 14, 2025
Comment on lines
+2022
to
+2026
| std::string confPath; | ||
| for (const auto& yamlIter : yamlStep) | ||
| { | ||
| confPath = yamlIter.as<std::string>(); | ||
| } |
There was a problem hiding this comment.
why do we reinitializing that string in a loop?
Maybe just std::string confPath = yamlStep[0].as<std::string>(); is enough?
|
|
||
| std::string resExec = exec(execCommand.c_str()); | ||
|
|
||
| printf("%s", resExec.data()); |
There was a problem hiding this comment.
just
Suggested change
| printf("%s", resExec.data()); | |
| std::cout <<resExec; |
Or use YANET_LOG_something. Using plain printf seems strange, after all, we're using C++
Comment on lines
+2043
to
+2047
| std::string command = "birdc "; | ||
| for (const auto& yamlIter : yamlStep) | ||
| { | ||
| command += yamlIter.as<std::string>() + " "; | ||
| } |
There was a problem hiding this comment.
Use std::ostringstream when building strings in a loop. Current approach is not efficient as you will gradually create more and more objects of increasing size.
Suggested change
| std::string command = "birdc "; | |
| for (const auto& yamlIter : yamlStep) | |
| { | |
| command += yamlIter.as<std::string>() + " "; | |
| } | |
| std::ostringstream command_stream; | |
| command_stream << "birdc "; | |
| for (const auto& yamlIter : yamlStep) | |
| { | |
| command_stream << yamlIter.as<std::string>() << ' '; | |
| } | |
| const std::string command = command_stream.str(); |
|
|
||
| auto res_birdc = exec(command.c_str()); | ||
|
|
||
| printf("birdc:\n %s\n", res_birdc.data()); |
There was a problem hiding this comment.
Suggested change
| printf("birdc:\n %s\n", res_birdc.data()); | |
| std::cout << "birdc:\n" << res_birdc << '\n'; |
| - bird/bird.conf | ||
| - birdc: | ||
| - show route | ||
| - sleep: 20 |
There was a problem hiding this comment.
is 20 second sleep absolutely needed? I would like to see a lesser value though if it's necessary, then feel free to ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.