Add nonterminating "hitcount" rule #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ol-imorozko
force-pushed
the
rule-counters
branch
2 times, most recently
from
4f3d75a to
fbaa76b
Compare
This commit introduces parsing for the hitcount rule. The tests and the actual semantics will be implemented later. The hitcount action is designed to count the number of times a rule is hit. It will be introduced in a ruleset as a duplecate of regular rule, but its action is hitcount instead of a terminating action. The hitcount values will be aggregated and returned upon request. We use "hitcount" instead of just "count" to not interfere with IPFW "count" rule.
ol-imorozko
force-pushed
the
rule-counters
branch
from
88d8302 to
53fea02
Compare
ol-imorozko
changed the title
ol-imorozko
force-pushed
the
rule-counters
branch
2 times, most recently
from
407e561 to
14a14e9
Compare
On rule execution we populate an unordered_map stored in dataplane
Right now, only "acl" is supported
ol-imorozko
force-pushed
the
rule-counters
branch
from
14a14e9 to
582d79a
Compare
GeorgyKirichenko
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hitcount action is designed to count the number of times a rule is hit.
It will be introduced in a ruleset as a duplecate of regular rule,
but its action is hitcount instead of a terminating action.
The hitcount values will be aggregated and returned upon request.
We use "hitcount" instead of just "count" to not interfere with IPFW
"count" rule.