Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add quartz style cron capability #4

Merged
merged 4 commits into from
Mar 24, 2024

Conversation

yamilmedina
Copy link
Owner

@yamilmedina yamilmedina commented Mar 24, 2024

In this PR

Feature

  • Quartz like compatibility for the Cron expression output, meaning 6 tokens and usage of "?"

Chore

  • Adds tests coverage for more and new cases.
  • Simplifies and the usage of the cron parser and docs.

@yamilmedina yamilmedina self-assigned this Mar 24, 2024
Copy link

github-actions bot commented Mar 24, 2024

Test Results

    2 files  +    1      2 suites  +1   0s ⏱️ ±0s
  98 tests +  49    98 ✔️ +  49  0 💤 ±0  0 ±0 
294 runs  +245  294 ✔️ +245  0 💤 ±0  0 ±0 

Results for commit bd6fb4b. ± Comparison against base commit c9c1a27.

This pull request removes 49 and adds 98 tests. Note that renamed tests count towards both.
io.github.yamilmedina.kron.NaturalKronParserTest ‑ [10] CASE_10
io.github.yamilmedina.kron.NaturalKronParserTest ‑ [11] CASE_11
io.github.yamilmedina.kron.NaturalKronParserTest ‑ [12] CASE_12
io.github.yamilmedina.kron.NaturalKronParserTest ‑ [13] CASE_13
io.github.yamilmedina.kron.NaturalKronParserTest ‑ [14] CASE_14
io.github.yamilmedina.kron.NaturalKronParserTest ‑ [15] CASE_15
io.github.yamilmedina.kron.NaturalKronParserTest ‑ [16] CASE_16
io.github.yamilmedina.kron.NaturalKronParserTest ‑ [17] CASE_17
io.github.yamilmedina.kron.NaturalKronParserTest ‑ [18] CASE_18
io.github.yamilmedina.kron.NaturalKronParserTest ‑ [19] CASE_19
…
io.github.yamilmedina.kron.NaturalKronDefaultStyleParserTest ‑ [10] CASE_10
io.github.yamilmedina.kron.NaturalKronDefaultStyleParserTest ‑ [11] CASE_11
io.github.yamilmedina.kron.NaturalKronDefaultStyleParserTest ‑ [12] CASE_12
io.github.yamilmedina.kron.NaturalKronDefaultStyleParserTest ‑ [13] CASE_13
io.github.yamilmedina.kron.NaturalKronDefaultStyleParserTest ‑ [14] CASE_14
io.github.yamilmedina.kron.NaturalKronDefaultStyleParserTest ‑ [15] CASE_15
io.github.yamilmedina.kron.NaturalKronDefaultStyleParserTest ‑ [16] CASE_16
io.github.yamilmedina.kron.NaturalKronDefaultStyleParserTest ‑ [17] CASE_17
io.github.yamilmedina.kron.NaturalKronDefaultStyleParserTest ‑ [18] CASE_18
io.github.yamilmedina.kron.NaturalKronDefaultStyleParserTest ‑ [19] CASE_19
…

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 79.41176% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 84.80%. Comparing base (c9c1a27) to head (bd6fb4b).

Files Patch % Lines
...otlin/io/github/yamilmedina/kron/KronExpression.kt 73.07% 2 Missing and 5 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   84.22%   84.80%   +0.58%     
==========================================
  Files          15       16       +1     
  Lines         412      441      +29     
  Branches       59       69      +10     
==========================================
+ Hits          347      374      +27     
+ Misses         38       34       -4     
- Partials       27       33       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yamilmedina yamilmedina merged commit 1d48725 into main Mar 24, 2024
2 checks passed
@yamilmedina yamilmedina deleted the feat/add-quartz-cron-capability branch March 24, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants