-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix existing and add missing meta-data #199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo question/comment.
Have you used a script to generate the entries? If so, then it may be useful to integrate it into the CI as a sort of "format checker" for future PRs. |
Indeed I had, but there were a bunch of one-off scripts that are slowly converging. When I'm done, I can make it available, though I do not want to be too strict with CI so to not discourage submissions. Also, the script uses a local JSON file as a cache to avoid hitting DBLP with too many requests. Can this be persisted through PRs? |
I don't think we should be strict either. Such a script should simply check our existing style guidelines programmatically, it would be convenient. And yes, we can persist files by having the CI upload an artifact after a successful run. |
In case anyone wants to play around with GitHub actions, here is the final script I've used to update the bibliography: https://gist.github.com/matijapretnar/926db074d96b51b8aa079f66cc785e11. I did the arXiv changes manually, so that is not in yet. If you run it, you get the updated |
Thanks! I will experiment with it at a later time. |
I've now gone through all the papers in the list and updated all of those that exist in DBLP (add DOI, BibTeX, fix typos, use official title capitalisation). I think we can consider #8 closed.