Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface with xtrack/xfields for tracking with wakes #17

Merged
merged 334 commits into from
Nov 20, 2024

Conversation

lgiacome
Copy link
Collaborator

Description

We add all the features needed for using in xtrack/xfields wakes coming from xwakes.

We include a number of tests and examples showing how to track with wakes.
We also add a folder with mpi tests, which will have to be added to the test suite.

Checklist

Mandatory:

  • I have added tests to cover my changes
  • All the tests are passing, including my new ones
  • I described my changes in this PR description

Optional:

  • The code I wrote follows good style practices (see PEP 8 and PEP 20).
  • I have updated the docs in relation to my changes, if applicable
  • I have tested also GPU contexts

@lgiacome lgiacome force-pushed the feature/avoid_multitracker branch from 8d4a6e7 to dcd1877 Compare November 18, 2024 16:06
xwakes/wit/interface.py Outdated Show resolved Hide resolved
xwakes/wit/component.py Show resolved Hide resolved
xwakes/wit/component.py Outdated Show resolved Hide resolved
xwakes/wit/component.py Show resolved Hide resolved
xwakes/wit/component.py Outdated Show resolved Hide resolved
xwakes/wit/component.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@nmounet nmounet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review finished! many thanks for the great work.

There remains a few minor things to check (many comments are for later PRs)

tests/test_utilities.py Show resolved Hide resolved
xwakes/wit/component.py Show resolved Hide resolved
xwakes/wit/component.py Show resolved Hide resolved
xwakes/wit/component.py Outdated Show resolved Hide resolved
xwakes/wit/component.py Show resolved Hide resolved
xwakes/wit/utilities.py Outdated Show resolved Hide resolved
@lgiacome lgiacome merged commit 0ee14e8 into main Nov 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants