Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New API SDK v2 #15

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

New API SDK v2 #15

wants to merge 5 commits into from

Conversation

plewy
Copy link

@plewy plewy commented Apr 27, 2016

New SDK for v2 API
Don't have all examples in readme.
And url in cofig for API is app-staging

@m-vdb
Copy link
Contributor

m-vdb commented May 13, 2016

why the chmods?

@@ -0,0 +1,11 @@
# -*- coding: utf-8 -*-
API_URL = 'https://app.xplenty.com/{}/api'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plewy This should be api.xplenty.com

@motymichaely
Copy link
Member

@m-vdb What do you mean?

change app to api in subdomain
@m-vdb
Copy link
Contributor

m-vdb commented May 13, 2016

@motymichaely the diff includes permission changes on the files. I don't think it's right :)
screen shot 2016-05-13 at 08 13 50

@motymichaely
Copy link
Member

@m-vdb I didn't notice that! Nice catch :)
@plewy any reason for the file mode changes?

@plewy
Copy link
Author

plewy commented May 15, 2016

Its taken from repository, 644 is engught for API files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants