-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable multiple Digital & Events #1832
Conversation
The only thing i don't know is how to set |
You might want to also add mapping from the old |
|
Append html settings section programmatically? By direct actions I meant ws actions: espurna/code/espurna/relay.ino Line 698 in fbf2b71
Line 430 in fbf2b71
(thus directly requesting required actions instead of using one-shot settings) |
ok, what if i remove pulse-meter from this PR and create a separate once it's done? |
sure, that will work |
Btw, by that I meant to add something here https://github.com/xoseperez/espurna/blob/dev/code/espurna/config/deprecated.h |
@mcspr any other request? i think it can be changed otherwise |
Don't think so. Any other changes can be made in bulk with other sensors (and maybe even move sensor init to sensor classes themselves) Also, cc @lbdroid mentioned this #1529 (comment) |
That's ok, can this be merged? |
Done. |
I know let's call them preparation for future |
I know that there is going to be support for specifying all the things dynamically through browser but before that here is enhancement to support it now. This would also help for anyone finding #1815 as there is no code provided, only guidance