Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactiveProperty-5.0.0, System.Reactive-4.0.0 #327

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

IvanMurzak
Copy link
Contributor

@IvanMurzak IvanMurzak commented Feb 4, 2024

The NuGet package needs to respect a few constraints in order to be listed in the curated list:

  • Add a link to the NuGet package: https://www.nuget.org/packages/ReactiveProperty
  • It must have non-preview versions (e.g 1.0.0 but not 1.0.0-preview.1)
  • It must provide .NETStandard2.0 assemblies as part of its package
  • The lowest version added must be the lowest .NETStandard2.0 version available
  • The package has been tested with the Unity editor
  • The package has been tested with a Unity standalone player
    • if the package is not compatible with standalone player, please add a comment to a Known issues section to the top level readme.md
  • All package dependencies with .NETStandard 2.0 target must be added to the PR (respecting the same rules above)
    • Note that if a future version of the package adds a new dependency, this dependency will have to be added manually as well

Note: The server will be updated only when a new version tag is pushed on the main branch, not necessarily after merging this pull-request.

// TODO: Need to remove package dependencies based on Unity version. Because some Unity versions has some DLL already on board.
@IvanMurzak IvanMurzak changed the title Reactive property ReactiveProperty 5.0.0, System.Reactive 4.0.0 Feb 4, 2024
@IvanMurzak IvanMurzak changed the title ReactiveProperty 5.0.0, System.Reactive 4.0.0 ReactiveProperty-5.0.0, System.Reactive-4.0.0 Feb 5, 2024
@bdovaz bdovaz merged commit 7afa3f0 into xoofx:master Feb 12, 2024
2 checks passed
@IvanMurzak IvanMurzak deleted the ReactiveProperty branch February 13, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants