-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure the dependencies' versions match the registry #283
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. If you think this pull request should stay open, please remove the |
This pull request has been automatically marked as stale because it has not had recent activity. If you think this pull request should stay open, please remove the |
This pull request has been automatically marked as stale because it has not had recent activity. If you think this pull request should stay open, please remove the |
This pull request has been automatically marked as stale because it has not had recent activity. If you think this pull request should stay open, please remove the |
This reverts commit 062c10b.
This pull request has been automatically marked as stale because it has not had recent activity. If you think this pull request should stay open, please remove the |
This pull request has been automatically marked as stale because it has not had recent activity. If you think this pull request should stay open, please remove the |
This pull request has been automatically marked as stale because it has not had recent activity. If you think this pull request should stay open, please remove the |
UnityNuget has a code path that is trying to rewrite package dependencies such that their versions correspond to the ones in
registry.json
. For instance, consider the case of a package dependencyA [1.1.1, )
and a registry entry for that packageA [8.0.0]
. The code will try to change the dependency to referenceA: 8.0.0
, as that is what it finds in theregistry.json
.However, this version resolution, from 1.1.1 to 8.0.0 is broken. What currently happens is: the code looks-up all available packages A in the feed and stop at the first version that was compatible with the dependency (and not the registry). So if the feed has newer packages, say
A 9.0.0
, UnityNuget would find that first and rewrite the dependency asA: 9.0.0
, regardless of whether 9.0.0 was actually compatible with its ownregistry.json
Fixes #281