Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the dependencies' versions match the registry #283

Closed
wants to merge 3 commits into from

Conversation

bucurb
Copy link
Contributor

@bucurb bucurb commented Nov 22, 2023

UnityNuget has a code path that is trying to rewrite package dependencies such that their versions correspond to the ones in registry.json. For instance, consider the case of a package dependency A [1.1.1, ) and a registry entry for that package A [8.0.0]. The code will try to change the dependency to reference A: 8.0.0, as that is what it finds in the registry.json.

However, this version resolution, from 1.1.1 to 8.0.0 is broken. What currently happens is: the code looks-up all available packages A in the feed and stop at the first version that was compatible with the dependency (and not the registry). So if the feed has newer packages, say A 9.0.0, UnityNuget would find that first and rewrite the dependency as A: 9.0.0, regardless of whether 9.0.0 was actually compatible with its own registry.json

Fixes #281

Copy link

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the Stale label or comment on the pull request.

@github-actions github-actions bot added the Stale label Dec 23, 2023
@bdovaz bdovaz removed the Stale label Dec 28, 2023
Copy link

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the Stale label or comment on the pull request.

@github-actions github-actions bot added the Stale label Jan 28, 2024
@bdovaz bdovaz removed the Stale label Jan 28, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the Stale label or comment on the pull request.

@github-actions github-actions bot added the Stale label Feb 28, 2024
@bdovaz bdovaz removed the Stale label Feb 28, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the Stale label or comment on the pull request.

@github-actions github-actions bot added the Stale label Mar 30, 2024
@github-actions github-actions bot removed the Stale label Apr 13, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the Stale label or comment on the pull request.

@github-actions github-actions bot added the Stale label May 13, 2024
@bdovaz bdovaz removed the Stale label May 13, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the Stale label or comment on the pull request.

@github-actions github-actions bot added the Stale label Jun 13, 2024
@github-actions github-actions bot closed this Jun 27, 2024
@bdovaz bdovaz reopened this Jun 27, 2024
@github-actions github-actions bot removed the Stale label Jun 28, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the Stale label or comment on the pull request.

@github-actions github-actions bot added the Stale label Jul 28, 2024
@github-actions github-actions bot closed this Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in how the registry checks for fulfilled dependencies?
2 participants