-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MQTTnet package #258
Add MQTTnet package #258
Conversation
2023-10-06T12:33:32.4929492Z |
@TapioRantala please, run tests locally Failed Ensure_That_Packages_Already_Included_In_Net_Standard_Are_not_Included_In_The_Registry [140 ms] |
This pull request has been automatically marked as stale because it has not had recent activity. If you think this pull request should stay open, please remove the |
I believe the concerns have been addressed now and this is ready to be merged. |
Please, check comment @TapioRantala |
Tests are passing, please clarify. |
The version is not the first version available on .NETStandard2.0, that would be 2.5.1.
There are additional dependencies listed for versions before 3.0.15:
NETStandard.Library (>= 2.0.0)
System.Net.Security (>= 4.3.2)
System.Net.WebSockets (>= 4.3.0)
System.Net.WebSockets.Client (>= 4.3.1)
System.Threading.Thread (>= 4.3.0)
These look like they are part of the .NETStandard2.0 itself?
Not sure if I should add those with "ignore": true or if having not-lowest-version is ok.