Skip to content

Commit

Permalink
Merge MR 'Update AMD Windows black texture bug fix hack to work on ne…
Browse files Browse the repository at this point in the history 
…wer GPUs'

See merge request https://gitlab.com/xonotic/darkplaces/-/merge_requests/157

Signed-off-by: bones_was_here <[email protected]>
  • Loading branch information
@bones-was-here
bones-was-here committed Aug 7, 2024
2 parents 9e7a350 + a93448b commit 2608c8b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion vid_shared.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -783,7 +783,7 @@ void GL_Setup(void)
// gl_texturecompression_color is somehow broken on AMD's Windows driver,
// see: https://gitlab.com/xonotic/darkplaces/-/issues/228
// HACK: force it off (less bad than adding hacky checks to the renderer)
if (strncmp(gl_renderer, "AMD Radeon(TM)", 14) == 0)
if (strncmp(gl_renderer, "AMD Radeon", 10) == 0)
{
Cvar_SetQuick(&gl_texturecompression_color, "0");
gl_texturecompression_color.flags |= CF_READONLY;
Expand Down

1 comment on commit 2608c8b

@oeai
Copy link

@oeai oeai commented on 2608c8b Aug 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better to get GPU instruction set and put that in some other class of render properties and CPU also - it's much more needed, than the joystick axis
i see ifdef WIN32 - but in terms of textureCompression it should be the same for x32 / x64 win or x86 linux, but between AMD / Intel / Nvidia / ARM / Apple / Snapdragon / Exynos - this can be different, i mean instruction set supported or texture class DXT or something

from this point i'm affraid - you're not using x64 instructions of CPU, that was there since early amd, but not intel
this can make hard to compile things or just get better math instructions
so getting all this stuff into new class and use that instead of outdated functions - can be a better workflow

Please sign in to comment.