patch: simplify mocktr181 HandleWrp and handle empty payload case #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
denopink
commented
Aug 6, 2024
denopink
commented
- support empty payload case (520 status code)
- simplify mocktr181 HandleWrp
- support empty payload case (520 status code) - simplify mocktr181 HandleWrp
denopink
commented
Aug 6, 2024
| statusCode = int64(520) | ||
| ) | ||
|
|
||
| if len(wrpPayload) == 0 { |
There was a problem hiding this comment.
support empty payload case (520 status code)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
=======================================
Coverage 77.39% 77.40%
=======================================
Files 75 75
Lines 4640 4642 +2
=======================================
+ Hits 3591 3593 +2
Misses 851 851
Partials 198 198
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
denopink
deleted the
denopink/patch/simplify-mocktr181-HandleWrp-structure
branch
piccione99
reviewed
Aug 6, 2024
| ) | ||
|
|
||
| if len(wrpPayload) == 0 { | ||
| return statusCode, []byte(fmt.Sprintf(`{"message": ""Invalid Input Command"", "statusCode": %d}`, statusCode)), nil |
There was a problem hiding this comment.
can we say empty so we know the payload is empty?
There was a problem hiding this comment.
I think we would but that's the expected behavior of the old c simulator.
we're trying to match the old c simulator as close as possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.