-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch: update mock181's get, check for non-readable or non-existing parameters #194
Conversation
1584ec2
to
8c06497
Compare
failedNames = append(failedNames, mockParameter.Name) | ||
} | ||
|
||
if !found { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added case when a requested parameter is not found
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
==========================================
+ Coverage 76.97% 77.20% +0.23%
==========================================
Files 75 75
Lines 4529 4540 +11
==========================================
+ Hits 3486 3505 +19
+ Misses 842 836 -6
+ Partials 201 199 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
During mock181's get: - check for any non-readable params - if any param is not readable, do not return any parameters that succeeded - add case when request param is not found - update wildcard case
8c06497
to
943336d
Compare
|
||
// If requested parameter is a wild card and mockParameter is not readable, | ||
// then continue and don't count it as a failure. | ||
if name[len(name)-1] == '.' { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update wildcard case
During mock181's get: