Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ErrBucketNotFound bugfix #171

Merged
merged 8 commits into from
May 6, 2021
Merged

ErrBucketNotFound bugfix #171

merged 8 commits into from
May 6, 2021

Conversation

joe94
Copy link
Member

@joe94 joe94 commented May 6, 2021

No description provided.

@codecov
Copy link

codecov bot commented May 6, 2021 •
edited
Loading

Codecov Report

Merging #171 (e8bd806) into main (d54494d) will increase coverage by 1.49%.
The diff coverage is 96.15%.

❗ Current head e8bd806 differs from pull request most recent head ae9bbf9. Consider uploading reports for the commit ae9bbf9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   61.70%   63.20%   +1.49%     
==========================================
  Files          16       16              
  Lines         901      875      -26     
==========================================
- Hits          556      553       -3     
+ Misses        316      306      -10     
+ Partials       29       16      -13
Impacted Files Coverage Δ
store/errors.go 11.11% <0.00%> (+1.11%) ⬆️
store/inmem/InMem.go 93.93% <100.00%> (+33.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d54494d...ae9bbf9. Read the comment docs.

@joe94 joe94 linked an issue May 6, 2021 that may be closed by this pull request
Bucket not found error #169
Closed
@joe94 joe94 mentioned this pull request May 6, 2021
Closed
@joe94 joe94 requested a review from kristinapathak May 6, 2021 17:18
kristinapathak
kristinapathak reviewed May 6, 2021
View reviewed changes
store/errors.go Show resolved Hide resolved
store/inmem/InMem.go Show resolved Hide resolved
kristinapathak
kristinapathak approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@kristinapathak kristinapathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@joe94 joe94 merged commit 2e9ab1c into main May 6, 2021
@joe94 joe94 deleted the bugfix/inMemErr branch May 6, 2021 18:41
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristinapathak kristinapathak kristinapathak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bucket not found error
2 participants
@joe94 @kristinapathak