remove span error mark

xinpianchang · Jul 23, 2021 · a3ccc46 · a3ccc46
1 parent bf7e5ec
commit a3ccc46
Showing 1 changed file with 0 additions and 13 deletions.
diff --git a/pkg/log/spanlogger.go b/pkg/log/spanlogger.go
@@ -7,7 +7,6 @@ import (
 	"time"
 
 	"github.com/opentracing/opentracing-go"
-	"github.com/opentracing/opentracing-go/ext"
 	"github.com/opentracing/opentracing-go/log"
 	"go.uber.org/zap"
 	"go.uber.org/zap/zapcore"
@@ -52,14 +51,12 @@ func (t spanLogger) Warn(msg string, fields ...zapcore.Field) {
 // Error log message
 func (t spanLogger) Error(msg string, fields ...zapcore.Field) {
 	t.logToSpan("error", msg, fields...)
-	t.markError()
 	t.logger.Error(msg, append(t.spanFields, fields...)...)
 }
 
 // Fatal log message
 func (t spanLogger) Fatal(msg string, fields ...zapcore.Field) {
 	t.logToSpan("fatal", msg, append(t.additionalFields, fields...)...)
-	t.markError()
 	t.logger.Fatal(msg, append(t.spanFields, fields...)...)
 }
 
@@ -94,16 +91,6 @@ func (t spanLogger) logToSpan(level string, msg string, fields ...zapcore.Field)
 	t.span.LogFields(fs...)
 }
 
-func (t spanLogger) markError() {
-	ek := "__error"
-	if t.span.BaggageItem(ek) != "" {
-		return
-	}
-
-	t.span.SetBaggageItem(ek, "true")
-	ext.Error.Set(t.span, true)
-}
-
 // zapFieldToLogField to opentracing log field
 func zapFieldToLogField(field zapcore.Field) log.Field {
 	switch field.Type {