Add "readwire" interface to *some* Graphene Types. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful when you want to *read* the serialized wire protocol back into objects-in-memory. Although this is rarely used on the client side of graphene networks, at least one particular use case (BitShares blind transfers) exists. To clarify: this is __bytes__ method in reverse. The `_readwire` interface and method signature are pretty horrid, so some redesign might be required.
Codecov Report
@@ Coverage Diff @@
## develop #65 +/- ##
===========================================
- Coverage 98.69% 98.34% -0.35%
===========================================
Files 24 24
Lines 1452 1515 +63
Branches 130 135 +5
===========================================
+ Hits 1433 1490 +57
- Misses 16 19 +3
- Partials 3 6 +3
Continue to review full report at Codecov.
|
6 tasks
|
Would it be possible to add unit tests for those? |
|
Instead of calling those methods _rewrite, can we have them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when you want to read the serialized wire protocol back into objects-in-memory. Although this is rarely used on the client side of graphene networks, at least one particular use case (BitShares blind transfers) exists.
To clarify: this is
__bytes__method in reverse.The
_readwireinterface and method signature are pretty horrid, so some redesign might be required.