Ensure that HalConfiguration MediaTypeConfigurationCustomizers are always run #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NielsCW
reviewed
Nov 18, 2024
|
I noticed. |
vierbergenlars
force-pushed
the
always-apply-mediatype-customizers
branch
from
4af1c4d to
bdba3eb
Compare
…ways run spring-data-rest is not aware of the existence of MediaTypeConfigurationCustomizer, so it does not apply the configuration when pulling the HalConfiguration bean directly. This leads to the configuration settings in HalConfiguration inconsistently being applied, depending on if a setting is used in spring-hateoas or spring-data-rest. Always applying all customizers directly in a BeanPostProcessor ensures that the HalConfiguration bean itself has all the customizations directly baked-in, and does not require all consumers to be aware of MediaTypeConfigurationCustomizer
vierbergenlars
force-pushed
the
always-apply-mediatype-customizers
branch
from
bdba3eb to
5a0d836
Compare
|
NielsCW
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cg:content&cg:relationlinks are not an array when there is only a single value.This happens because spring-data-rest does not process
MediaTypeConfigurationCustomizer, so it does not apply the configuration when pulling theHalConfigurationbean directly.This leads to the configuration settings in
HalConfigurationinconsistently being applied, depending on if a setting is used in spring-hateoas or spring-data-rest.Always applying all customizers directly in a
BeanPostProcessorensures that the HalConfiguration bean itself has all the customizations directly baked-in,and does not require all consumers to be aware of
MediaTypeConfigurationCustomizer.This does result in
MediaTypeConfigurationCustomizers being applied twice whereHalConfigurationis used in spring-hateoas,but all usual configurations are idempotent anyways (e.g. adding configuration for a link relation, or setting the ObjectMapper customizer)