Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ValueError: unsupported format character ',' (0x2c) at index 27 #10

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

christianmeyer
Copy link
Contributor

@christianmeyer christianmeyer commented Jul 19, 2024

In context of AWS Identity Center based profiles I observed an error out of a typo in the error handling, which this is the fix for.

Traceback (most recent call last):
  File "/Users/username/.local/pipx/venvs/awsume/lib/python3.12/site-packages/1password.py", line 110, in pre_get_credentials
    'No access key for profile %, skip plugin flow'
ValueError: unsupported format character ',' (0x2c) at index 27

@sogaoh
Copy link

sogaoh commented Sep 15, 2024

I ran into the same problem.
I think it's a reasonable fix, please merge.

@xeger
Copy link
Owner

xeger commented Jan 18, 2025

Accepted; thank you, and sorry for the delay.

@xeger xeger merged commit 5921543 into xeger:main Jan 18, 2025
@xeger
Copy link
Owner

xeger commented Jan 18, 2025

Published as v1.2.4

@sogaoh
Copy link

sogaoh commented Jan 18, 2025

@xeger

Published as v1.2.4

Thank you.
How can I update to v1.2.4?

It looks like the Release only goes up to v1.2.2

@xeger
Copy link
Owner

xeger commented Jan 20, 2025

Check PyPI, there is a 1.2.4 available now.

https://pypi.org/project/awsume-1password-plugin

@sogaoh
Copy link

sogaoh commented Jan 20, 2025

I see. I understand.
If possible, I would appreciate it if you could also update the Releases on GitHub.

CleanShot 2025-01-21 at 08 25 21@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants