Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add lockfile update action to manually trigger for dependabot PRs #3647

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

superlopuh
Copy link
Member

@superlopuh superlopuh commented Dec 16, 2024

I tested it here and it works if you do the dumb thing and trigger on push, but it seems to not run actions on unsigned commits by default. I'm hoping that if we trigger the action manually it'll inherit the clicker's permissions and re-run the action. In either case, I think whatever we adopt should supercede the cron job one as we want to never be out of sync between the pyproject and lockfile.

@superlopuh superlopuh added the CI Continuous Integration label Dec 16, 2024
@superlopuh superlopuh self-assigned this Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (91c2790) to head (4d5cc34).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3647      +/-   ##
==========================================
- Coverage   90.75%   90.75%   -0.01%     
==========================================
  Files         467      467              
  Lines       58905    58905              
  Branches     5639     5639              
==========================================
- Hits        53460    53458       -2     
- Misses       4001     4002       +1     
- Partials     1444     1445       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this needs to be manually run on dependabot prs?

@superlopuh
Copy link
Member Author

For now, yes

@superlopuh
Copy link
Member Author

Stop-gap until this beast is merged: dependabot/dependabot-core#10040

@superlopuh superlopuh merged commit a2505b3 into main Dec 16, 2024
16 checks passed
@superlopuh superlopuh deleted the sasha/uv/update-lockfile-action branch December 16, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants