Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorBarLegend component as submodule #326

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

forman
Copy link
Member

@forman forman commented Apr 24, 2024

ColorBarLegend component is now implemented in its own submodule.

At the same time it shall serve as a template for the decomposition many of the other large components such as SettingsDialog, UserPlacesDialog, Viewer, TimeSeriesChart, and a few more.

Template:

src/components/Component/
    index.tsx              // makes it a module and exports main component
    Component.tsx          // the main component
    SubComponent1.tsx
    SubComponent2.tsx
    ...
    SubComponentN.tsx

@forman forman marked this pull request as ready for review April 24, 2024 12:17
@forman forman requested a review from ruchimotwaniBC April 24, 2024 12:19
@forman forman self-assigned this Apr 24, 2024
@forman forman merged commit e054e81 into main Apr 24, 2024
3 checks passed
@forman forman deleted the forman-ColorBarLegend_is_submodule branch April 26, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants