[17.0][MIG] hr_leave_custom_hour_interval: Migration to 17.0 #1
Conversation
[UPD] Update hr_leave_hour.pot [UPD] README.rst [ADD] icon.png
[UPD] Update hr_leave_custom_hour_interval.pot [UPD] README.rst
Currently translated at 100.0% (5 of 5 strings) Translation: hr-holidays-15.0/hr-holidays-15.0-hr_leave_custom_hour_interval Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-15-0/hr-holidays-15-0-hr_leave_custom_hour_interval/it/
xaviedoanhduy
force-pushed
the
17.0-mig-hr_leave_custom_hour_interval
branch
from
51a6520 to
824fc89
Compare
| * `Trobz <https://trobz.com>`_: | ||
| * Duy Do Anh <[email protected]> |
There was a problem hiding this comment.
- Duy Do Anh <[email protected]>, then run pre-commit again
- lgtm overall
xaviedoanhduy
force-pushed
the
17.0-mig-hr_leave_custom_hour_interval
branch
6 times, most recently
from
17ea0d2 to
b7bc00a
Compare
| def _compute_date_from_to(self): | ||
| return super()._compute_date_from_to() | ||
|
|
||
| def action_validate(self): |
There was a problem hiding this comment.
@xaviedoanhduy could you please share your ideas about this override?
exclude_public_holidays is not existed btw
There was a problem hiding this comment.
hi @dzungtran89, I am trying to fix failed tests in the hr_holidays_public module when overriding the action_validate function.
some pr is exists do the same in here
There was a problem hiding this comment.
you can get the error log in here
There was a problem hiding this comment.
File "/__w/hr-holidays/hr-holidays/hr_holidays_public/tests/test_holidays_calculation.py", line 188, in test_number_of_hours_excluding_employee_2
leave_request.action_validate()
File "/__w/hr-holidays/hr-holidays/hr_leave_custom_hour_interval/models/hr_leave.py", line 47, in action_validate
return super().action_validate()
File "/__w/hr-holidays/hr-holidays/hr_holidays_public/models/hr_leave.py", line 22, in action_validate
return super().action_validate()
File "/opt/odoo/addons/hr_holidays/models/hr_leave.py", line 1385, in action_validate
employee_requests._validate_leave_request()
File "/opt/odoo/addons/hr_holidays/models/hr_leave.py", line 1112, in _validate_leave_request
holiday.message_post(
File "/opt/odoo/addons/mail/models/mail_thread.py", line 2096, in message_post
raise ValueError(_("Posting a message should be done on a business document. Use message_notify to send a notification to an user."))
ValueError: Posting a message should be done on a business document. Use message_notify to send a notification to an user.
You could take some times to investigate the issue on the module hr_holidays_public, the module hr_leave_custom_hour_interval is not relevant
btw, A new commit is quite recent odoo/odoo/commit/9f1aaec55fff6 which triggers a message post in the action_validate
There was a problem hiding this comment.
hi @dzungtran89, the overide about action_validate fuction is removed from this PR. so now I can create PR with OCA right?
xaviedoanhduy
force-pushed
the
17.0-mig-hr_leave_custom_hour_interval
branch
from
b7bc00a to
db76320
Compare
The failing test not related to this module