CA-403620: Drop the usage of fuser in stunnel client proxy #6197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why isn't the function that uses fuser dropped? ( |
Thanks! It had been in my mind when doing the change but I chose to defer it later. Missed this completely when raising PR :( |
psafont
approved these changes
Jan 2, 2025
Vincent-lau
approved these changes
Jan 3, 2025
The drawback of fuser is that it gets too many things involved. E.g. it is observed that it got stuck on cifs kernel module. This change uses a cleaner way to remember the stunnel client proxy. Even when the xapi restarted unexpectedly, it can stop the remnant stunnel proxy and start a new one. Signed-off-by: Ming Lu <[email protected]>
Making it configurable can avoid the situation when the port conflicts with others, e.g. an external program from users. Signed-off-by: Ming Lu <[email protected]>
minglumlu
force-pushed
the
private/mingl/CA-403620
branch
from
6d91109 to
e7f2b70
Compare
lindig
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes in the PR:
Drop the usage of fuser in stunnel client proxy
The drawback of fuser is that it gets too many things involved. E.g. it
is observed that it got stuck on cifs kernel module.
This change uses a cleaner way to remember the stunnel client proxy.
Even when the xapi restarted unexpectedly, it can stop the remnant
stunnel proxy and start a new one.
Make the stunnel proxy local port configurable
Making it configurable can avoid the situation when the port conflicts
with others, e.g. an external program from users.