CA-368437 remove duplicate keys from SM.features #5493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport of 2386ed7 The association list SM.features frequently contains duplicate keys. This is problematic because they could bind to different values (which are versions in this case). When parsing the features from a list of strings, eliminate duplicate keys. In addition, simplify the implementation and avoid duplicate work by using List.filter_map. Signed-off-by: Christian Lindig <[email protected]>
robhoes
approved these changes
Mar 8, 2024
edwintorok
reviewed
Mar 8, 2024
edwintorok
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of 2386ed7
The association list SM.features frequently contains duplicate keys. This is problematic because they could bind to different values (which are versions in this case).
When parsing the features from a list of strings, eliminate duplicate keys. In addition, simplify the implementation and avoid duplicate work by using List.filter_map.